Re: CVS commit: src/share/mk

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Mon, Mar 10, 2008 at 00:08:18 -0400, David Holland wrote:

> On Mon, Mar 10, 2008 at 06:33:49AM +0300, Valeriy E. Ushakov wrote:
>  > > Otherwise, grep NOMAN /usr/share/mk/*.mk comes up empty, and since
>  > > naively setting it may not work, one can easily draw wrong
>  > > conclusions.
>  > 
>  > I don't think you can win here.  If you start down that path you will
>  > have to rewrite half of bsd.own.mk, consider e.g. loops directly after
>  > the one you've changed.
>  > 
>  > So I think this change was superfluous.
> 
> Possibly, but it doesn't hurt. (And unlike the various other possible
> cases, I *did* trip on this one.)
> 
> I'm not planning a general rototill, in any event.

So why single out this particular case?  We have lots of places where
names are macro-generated (USE_* in the very same bsd.own.mk, spl*,
bus space methods, etc, etc...).  Are you going to "fix" them every
time you do trip on another random instance of macroified name?

Please, revert it.

SY, Uwe
-- 
uwe%stderr.spb.ru@localhost                       |       Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/          |       Ist zu Grunde gehen