Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic/dp8390.c



On Sat, Feb 23, 2008 at 02:26:53AM +0000, David Young wrote:
> Modified Files:
>       src/sys/dev/ic: dp8390.c
> 
> Log Message:
> ENODEV and ENOTTY are appropriate error codes for indicating
> unsupported ioctls, but EINVAL is definitely not!  If an operation
> is not supported, return ENODEV instead of EINVAL.

ENOTTY is the standard error code to return when the device doesn't support
an ioctl.  Shouldn't you return that?

--chb


Home | Main Index | Thread Index | Old Index