Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys/dev/pci



Module Name:    src
Committed By:   drochner
Date:           Thu Feb 21 22:26:35 UTC 2008

Modified Files:
        src/sys/dev/pci: agp_intel.c agpreg.h

Log Message:
clean up the error bit clear code:
-use an aligned pci config space address as everyone else -- I'm sorry
 about that because I like gson's way a lot -- it keeps the address
 offset due to alignment visually close to the data shift --, but since
 aligned addresses are used everywhere else in definitions, this
 causes confusion
-the mask applied to the data didn't make much sense, a look at the
 FreeBSD code where this code originates from suggests that there
 was just a mistake -- one trailing zero missing --
 anyway, the datasheet tells that the error bits are all write-one-
 to-clear, so just write back the value and we are done


To generate a diff of this commit:
cvs rdiff -r1.28 -r1.29 src/sys/dev/pci/agp_intel.c
cvs rdiff -r1.17 -r1.18 src/sys/dev/pci/agpreg.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



Home | Main Index | Thread Index | Old Index