Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make



On Feb 16,  4:18pm, dholland+sourcechanges%eecs.harvard.edu@localhost (David 
Holland) wrote:
-- Subject: Re: CVS commit: src/usr.bin/make

| On Sat, Feb 16, 2008 at 02:53:09PM +0000, David Laight wrote:
|  > > Log Message:
|  > > back all changes out until I fix it properly.
|  > 
|  > I've found out why the change broke things so badly..
|  > 
|  > JobDoOutput() contains:
|  > [snip]
|  > 
|  > If the buffer being scanned doesn't contain a '\n', and curPos is zero
|  > the we (now) trundle back through memory replacing '\0' with ' '
|  > until we reach a '\n'.
| 
| Yes, that was the problem I fixed. There was at least one more...

You missed the case where nr > 0 and curPos == 0.

christos


Home | Main Index | Thread Index | Old Index