Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/i386/stand/genprom



> Alan Barrett <apb%cequrux.com@localhost> writes:
> > Since bail() doesn't return, it seems to me that the __dead marker was
> > correct.  The proper fix is not to remove the __dead, but to change the
> > build so that __dead is defined.
> 
> Compiles with high WARNS levels would now fail...

Have you tried compiling with a high WARNS level? No errors are
thrown, since <bsd.hostprog.mk> doesn't do anything with WARNS.
In any case: the only time a warning would be emitted is if you
(rather inexplicably) turned on -Wmissing-noreturn - which isn't
enabled by any other -W flags.

As far as fixing the build so that __dead doesn't produce compiler
warnings - please follow up to my query on tech-misc, message-id
<20071226105053.GB23538%babymeat.com@localhost>, which addresses precisely
this sort of issue. (Alternately, patch the code in whatever
fashion is acceptable.)




Home | Main Index | Thread Index | Old Index