Re: CVS commit: src/sys/dev

[David Young <dyoung%pobox.com@localhost>]

On Mon, Dec 17, 2007 at 03:11:40PM +0100, Joerg Sonnenberger wrote:
> On Sun, Dec 16, 2007 at 12:04:08AM +0000, David Young wrote:
> > Log Message:
> > Synchronize device detachment with network interrupts.  Use the
> > pmf network class instead of powerhooks.
> 
> You changed a kassert-like check to a full runtime check, is that
> intentional? KASSERT would be fine here, I guess.
> 
> Joerg

On Mon, Dec 17, 2007 at 03:12:36PM +0100, Joerg Sonnenberger wrote:
> On Sun, Dec 16, 2007 at 12:04:08AM +0000, David Young wrote:
> > Log Message:
> > Synchronize device detachment with network interrupts.  Use the
> > pmf network class instead of powerhooks.
> 
> Please also nuke the shutdown hook, it is redundant.
> 
> Joerg

Thanks for taking a look.  I will prepare a patch for these issues.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933 ext 24