Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci



On Sun, Nov 25, 2007 at 04:02:17PM +1300, david.sainty%dtsp.co.nz@localhost 
wrote:
> But doesn't the fact it's crashing suggest that the reinitialisation
> isn't complete?  I.e. this patch fixes most crashes, but it could
> still crash if a legitimate interrupt comes in very early?

I'm not sure when exactly the interrupt occurs. What the driver was
doing is:

- disable interrupt generation
- hook up interrupt handler
- disable legacy support

Problem is that the third item can trigger interrupts and while the
interrupt handler does check for pending status bits (required for
shared interrupts), it can't deal with the children not being attached.

The patch runs with IPL protection around the third can explicitly acks
all valid interrupts :-)

Joerg



Home | Main Index | Thread Index | Old Index