Re: CVS commit: src/usr.bin/make

[Alan Barrett <apb%cequrux.com@localhost>]

On Fri, 12 Oct 2007, Simon Gerraty wrote:
> >> If _BASENAME_DEFSHELL is defined, it might be a full path,
> >> in which case we should not prepend _PATH_DEFSHELLDIR.
> >
> >If you do that, please rename the variable.  It's confusing to have a
> >variable whose name includes "BASENAME" but whose value is not always a
> >basename.
> 
> Ok, how about  _PATH_DEFSHELL ?

Well, it's not always a path, but I like _PATH_DEFSHELL better than
_BASENAME_DEFSHELL.

What about DEFSHELL or DEFSHELL_NAME for the basename or full path
of the default shell, and rename the existing DEFSHELL variable to
DEFSHELL_INDEX (an index into the shells[] array defined in job.c).

--apb (Alan Barrett)