Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



On Tue, Oct 02, 2007 at 06:41:37AM +0000, Tom Spindler wrote:

> > Modified Files:
> >     src/sys/kern: kern_idle.c kern_synch.c
> >     src/sys/sys: cpu.h
> > 
> > Log Message:
> > Enter mi_switch() from the idle loop if ci_want_resched is set. If there
> > are no jobs to run it will clear it while under lock. Should fix idle.
> 
> This breaks the kernel build for evbarm:
> 
> --- kern-CP3100 ---
> /home/dogcow/work/nbsrc/sys/kern/kern_idle.c: In function 'idle_loop':
> /home/dogcow/work/nbsrc/sys/kern/kern_idle.c:74: error: 'struct cpu_info' has 
> no member named 'ci_want_resched'
> *** [kern_idle.o] Error code 1

That should be fixed as of yesterday.

> I'm also a wee bit confused by the purpose of cpu_did_resched; it's currently
> not used by anything, and the various defines should almost certainly be
> something along the line of CPU_DID_RESCHED;, not in the pseudo () form.

I removed it, because all ports should now have cpu_info::ci_want_resched.
All it needs to do is clear that variable.

Thanks,
Andrew



Home | Main Index | Thread Index | Old Index