Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/envstat



> On Thu, 5 Jul 2007 11:51:15 +0200
> Juan RP <juan%xtrarom.org@localhost> wrote:
> 
> > On Thu,  5 Jul 2007 18:44:36 +0900 (JST)
> > yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> > 
> > > why not for indicators?
> > > 
> > > > Except Integer and Driver sensors, which shouldn't need that.
> > > 
> > > can you explain?
> > 
> > That should be "Integer and Drive sensors".
> 
> Erm, s/Integer/Indicator/
> 
> > Because I can't see any reason why these sensors should be shown when they
> > are in invalid state.
> > 
> > Drive sensors do not rely in the state field to report if a drive is
> > online or not, they use value_cur for this.

i don't understand your logic.
to me, it sounds like a reason not to exclude drive sensors.

> > Showing Indicator sensors if they are disabled is ugly and I would like to
> > not change many drivers only for this, I have explained the reason in a PR
> > to Greg. A. Woods before.

which PR?

YAMAMOTO Takashi



Home | Main Index | Thread Index | Old Index