Re: CVS commit: [itohy-usb1] src/sys/dev/usb

[itohy%NetBSD.org@localhost (ITOH Yasufumi)]

In article <20070622124622.8ff360bd.juan%xtrarom.org@localhost>
juan%xtrarom.org@localhost writes:

> Is there any reason to keep the #ifdef __OtherBSD__ anymore? even FreeBSD
> and OpenBSD removed these parts.

Yes.

- We are generous enough to give them our code with smallest cost.

- Having #ifdefs will help to merge their changes to our code.
  For example, if AnotherBSD has a code sequence

        A
        B
        C

  and if we have

        A
        #ifdef __AnotherBSD__
        B
        #endif
        C

  we can easily recognize the B is not needed for us.
  However, if we had removed AnotherBSD code and had a code sequence

        A
        C

  we would wonder if B would be required every time.

- If we have the master copy of USB stack of all BSDs, that may be
  fairly attractive to developers and users.

- Removing #ifdefs is very easy, but reverting them is very difficult.

- I think the #ifdefs are interesting itself, showing brokenness^Wdifference
  of other BSDs.

-- 
ITOH Yasufumi