Re: CVS commit: src/distrib/utils/sysinst

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

xtraeme%NetBSD.org@localhost wrote:

> Module Name:  src
> Committed By: xtraeme
> Date:         Mon Jun 18 16:58:42 UTC 2007
> 
> Modified Files:
>       src/distrib/utils/sysinst: disks.c
> 
> Log Message:
> Mount a ptyfs on /dev/pts by default. I'm committing it because
> I did not have any answer for 10 days.

I think more verbose log message (and a call for review) is preferred.

I guess it should be:
"Make sysinst also create a default entry of a ptyfs on /dev/pts
 in /etc/fstab on the target disk as well as kernfs and procfs,"
but your log message may imply that INSTALL kernels should have
"file-system PTYFS" option.

> http://mail-index.netbsd.org/tech-install/2007/06/08/0001.html

It might also be better to post diffs to a list directly
rather than via URL (unless it's too large to post) so that
more people would take a look at and comment about it properly.

---
@@ -497,11 +497,13 @@
                                tmp_mfs_size);
        }
 
-       /* Add /kern and /proc to fstab and make mountpoint. */
+       /* Add /kern, /proc and /dev/pts to fstab and make mountpoint. */
        scripting_fprintf(f, "kernfs\t\t/kern\tkernfs\trw\n");
+       scripting_fprintf(f, "ptyfs\t\t/dev/pts\tptyfs\trw\n");
        scripting_fprintf(f, "procfs\t\t/proc\tprocfs\trw,noauto\n");
        make_target_dir("/kern");
        make_target_dir("/proc");
+       make_target_dir("/dev/pts");
 
        scripting_fprintf(NULL, "EOF\n");
 
---
Izumi Tsutsui