Re: CVS commit: src/sys/fs/filecorefs

[christos%astron.com@localhost (Christos Zoulas)]

In article <597F06A7-9129-4E4F-A4DF-BF4930CFB90B%shagadelic.org@localhost>,
Jason Thorpe  <thorpej%shagadelic.org@localhost> wrote:
>
>On Mar 4, 2007, at 2:06 PM, Antti Kantee wrote:
>
>> On Sun Mar 04 2007 at 21:18:08 +0000, John Nemeth wrote:
>>>
>>> Module Name:        src
>>> Committed By:       jnemeth
>>> Date:               Sun Mar  4 21:18:08 UTC 2007
>>>
>>> Modified Files:
>>>     src/sys/fs/filecorefs: filecore_vfsops.c
>>>
>>> Log Message:
>>> more caddr_t -> void * fallout
>>>
>>>
>>> To generate a diff of this commit:
>>> cvs rdiff -r1.31 -r1.32 src/sys/fs/filecorefs/filecore_vfsops.c
>>
>> Is there any reason to not make b_un.b_addr char * or uint8_t *  
>> instead
>> of adding these casts to a gazillion places?
>
>Is it because of the pointer arithmetic?  How about "vaddr_t" ?

It is an integral type (unsigned long on x86) and it does not like array
deref, or easy assignments to and from pointers.

christos