Re: CVS commit: src/sys/dev/ic

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

christos%zoulas.com@localhost wrote:

> | > Modified Files:
> | >   src/sys/dev/ic: mb89352.c
> | > 
> | > Log Message:
> | > comment out impossible code
> | 
> | Isn't it better to make sc_dleft signed?
> | (maybe this code should be wrapped by #ifdef DIAGNOSTIC anyway)
> 
> I think that keeping things unsigned makes the code simpler. Having
> the checks always in the kernel prevents buffer overflows and crashes.

But you #if 0'ed out a check ("data xfered more than requested bytes")
which didn't work as intended because sc_dleft was unsigned.
---
Izumi Tsutsui