Re: CVS commit: src/sys/arch/i386

[Garrett D'Amore <garrett_damore%tadpole.com@localhost>]

Perry E. Metzger wrote:
> Garrett D'Amore <gdamore%netbsd.org@localhost> writes:
>   
>> Module Name: src
>> Committed By:        gdamore
>> Date:                Sun Sep  3 05:26:11 UTC 2006
>>
>> Modified Files:
>>      src/sys/arch/i386/include: types.h
>>      src/sys/arch/i386/isa: clock.c
>>
>> Log Message:
>> Convert i386 to use common TODR code.  Not tested, but Christos says he'll
>> test it for me right now. :-)
>>     
>
> The code that remains probably should be in something like
> sys/dev/isa, because it is completely shared between x86 and amd64 and
> any other machine that uses that RTC clock on an ISA bus could, in
> theory, use exactly the same code.
>
> Perry
>   

That would be nice.  Actually, the clock should be a _real_ device in
dev/isa.  Right now the i386 code is _not_ a real device (no CFATTACH
stuff), and probably full of i386-isms.   The code is very unclean, or
at least so it appeared to me.

I've not touched amd64, but if someone else wants to, please do so.  I
can't test, and I can't even compile test thanks to gcc4 cross-compiling
from Solaris being busted again.

-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191