Re: CVS commit: [gdamore-uart] src/sys/arch/m68k/fpsp

[Garrett D'Amore <garrett_damore%tadpole.com@localhost>]

Izumi Tsutsui wrote:
> garrett_damore%tadpole.com@localhost wrote:
>
>   
>> Looks fine to me, though I'd have used
>>
>> ${SED:=sed}
>>
>> instead.
>>     
>
> Is it okay to commit this?
>   

Why ${TOOL_SED:Q}  instead of ${TOOL_SED}?

On Solaris at least, the construct ${TOOL_SED:Q} generates a "bad
substitution" error.

    -- Garrett
> ---
> Izumi Tsutsui
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/m68k/fpsp/Makefile,v
> retrieving revision 1.14
> diff -u -r1.14 Makefile
> --- Makefile  18 Jun 2006 05:21:21 -0000      1.14
> +++ Makefile  20 Jun 2006 09:37:02 -0000
> @@ -77,9 +77,9 @@
>  PREFIX               = L_
>  
>  .sa.s:
> -     ${HOST_SH} ${FPSPDIR}/asm2gas ${TOOL_SED} ${.IMPSRC} >${.TARGET}
> +     SED=${TOOL_SED:Q} ${HOST_SH} ${FPSPDIR}/asm2gas ${.IMPSRC} >${.TARGET}
>  .h.defs:
> -     ${HOST_SH} ${FPSPDIR}/asm2gas ${TOOL_SED} ${.IMPSRC} >${.TARGET}
> +     SED=${TOOL_SED:Q} ${HOST_SH} ${FPSPDIR}/asm2gas ${.IMPSRC} >${.TARGET}
>  .s.o:
>       ${CC} ${AFLAGS} ${CPPFLAGS} -c -o ${.TARGET} ${.IMPSRC}
>  
> Index: asm2gas
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/m68k/fpsp/asm2gas,v
> retrieving revision 1.7
> diff -u -r1.7 asm2gas
> --- asm2gas   18 Jun 2006 05:21:21 -0000      1.7
> +++ asm2gas   20 Jun 2006 09:37:02 -0000
> @@ -40,8 +40,8 @@
>  # This ugly script converts assembler code from Motorola's format to a
>  # form that gas (MIT syntax) can digest.
>  
> -SED=$1
> -cat $2 | ${SED} -e '
> +: ${SED:=sed}
> +cat $1 | ${SED} -e '
>    # format canonicalization
>  
>    /[         ]IDNT[  ]/{s/^/|/;p;d;}
>   


-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191