Re: CVS commit: src/sys/ufs/ffs

[David Laight <david%l8s.co.uk@localhost>]

On Mon, Apr 10, 2006 at 10:01:06PM +0000, Manuel Bouyer wrote:
> 
> Module Name:  src
> Committed By: bouyer
> Date:         Mon Apr 10 22:01:06 UTC 2006
> 
> Modified Files:
>       src/sys/ufs/ffs: ffs_snapshot.c
> 
> Log Message:
> Revert previous; I mixed bpp and *bpp when reading ffs_balloc_ufs1().
> ffs_balloc() will always allocate a new buffer or leave it as NULL,
> so coverity is wrong here, we're not using a freed argument.

Yes - it took me a dozen reads of that code to realise it was ok.
Including looking at the pre-UBC version.
I suspect the logic is too complicated :-)

        David

-- 
David Laight: david%l8s.co.uk@localhost