Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/pkg_install/lib



On Sat, 18 Mar 2006, YAMAMOTO Takashi wrote:
Modified Files:
        src/usr.sbin/pkg_install/lib: str.c

Log Message:
findbestmatchingname_fn(): catch possible problems if best (vp)
contains some strange name (shouldn't happen, but ...)

Coverity CID 869

if it shouldn't happen as your comment says, why not abort processing?

The "shouldn't" is meant as "if everything goes well, it will not happen", not as "if this happens the world comes to an end". If that case is hit, it's most probably anything but something we're interested in, so a warning is printed and operation continues. There's no need to abort.


 - Hubert



Home | Main Index | Thread Index | Old Index