Re: CVS commit: src/sbin/sysctl

[Martin Husemann <martin%NetBSD.org@localhost>]

On Sun, Feb 05, 2006 at 10:42:55PM +0000, Christos Zoulas wrote:
> 
> Module Name:  src
> Committed By: christos
> Date:         Sun Feb  5 22:42:55 UTC 2006
> 
> Modified Files:
>       src/sbin/sysctl: sysctl.c
> 
> Log Message:
> PR/17441: John F. Woods: integer sysctl does not accept numbers > 0x7fffffff
> Use unsigned int in the range comparison, and use strerror() instead of
> home brewed error strings.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.109 -r1.110 src/sbin/sysctl/sysctl.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


This broke negative int values:

 # sysctl -w kern.rtc_offset=-60
 sysctl: -60: Result too large or too small

(tested on amd64, in case integer type length should matter)

Martin