Re: CVS commit: src/sys/lib/libsa

[Chuck Silvers <chuq%chuq.com@localhost>]

hi christos,

this new ip_cksum() always goes into an infinite loop
because you changed "len" to be unsigned.  this doesn't
work too well with loops like "while ((len -= 2) >= 0) {" ...

-Chuck


On Tue, Jan 24, 2006 at 05:07:19PM +0000, Christos Zoulas wrote:
> 
> Module Name:  src
> Committed By: christos
> Date:         Tue Jan 24 17:07:19 UTC 2006
> 
> Modified Files:
>       src/sys/lib/libsa: Makefile ether_sprintf.c net.h udp.c
> Added Files:
>       src/sys/lib/libsa: ip_cksum.c
> Removed Files:
>       src/sys/lib/libsa: in_cksum.c
> 
> Log Message:
> PR/32613: Yves-Emmanuel JUTARD: Incoherencies in file sys/lib/libsa/net.h
> - Make prototype of ether_sprintf() match the one in sys/net.
> - Rename in_cksum to ip_cksum and fix its prototype. in_cksum() operates
>   on an mbuf and ip_cksum() operates on a plain buffer. We should not call
>   functions that operate on different arguments the same name (this is not
>   c++).
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.57 -r1.58 src/sys/lib/libsa/Makefile
> cvs rdiff -r1.4 -r1.5 src/sys/lib/libsa/ether_sprintf.c \
>     src/sys/lib/libsa/udp.c
> cvs rdiff -r1.6 -r0 src/sys/lib/libsa/in_cksum.c
> cvs rdiff -r0 -r1.1 src/sys/lib/libsa/ip_cksum.c
> cvs rdiff -r1.18 -r1.19 src/sys/lib/libsa/net.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.