Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/miscfs/genfs



On Wed, Nov 30, 2005 at 10:59:33AM +0900, YAMAMOTO Takashi wrote:
> > Module Name:        src
> > Committed By:       reinoud
> > Date:               Wed Nov 30 01:46:06 UTC 2005
> > 
> > Modified Files:
> >     src/sys/miscfs/genfs: genfs_vnops.c
> > 
> > Log Message:
> > Learn genfs that (struct buf *)->b_lblkno allways need to point to the
> > logical block number of the file instead of allways zero.
> 
> for what is it necessary?

buffers passed from bread()/bwrite() have this field set up correctly 
whereas genfs just bluntly sets it to zero.

Note that there are other problems currently with buffer passing to 
strategy, see my PR # "kern/32193: vop_strategy gets broken struct buf's 
passed by genfs/bread, possible memory leakage"

For filingsystems that rely/want to do 1:1 mapping in bmap, its a PITA that 
suddenly the b_lblknr gets cleared and in one routine they have to manually 
correct this.

Cheers,
Reinoud

Attachment: pgpH1U4hFLd3w.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index