Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/compat/linux/common



On 2005.11.06 17:55:33 +0100, Jaromir Dolecek wrote:
| On Sun, Nov 06, 2005 at 03:30:40PM +0000, Emmanuel Dreyfus wrote:
| > On Sun, Nov 06, 2005 at 12:17:10PM +0000, Rui Paulo wrote:
| > > This broke i386 because it does not define LINUX_NPTL but has
| > > linux_sched_{get|set}affinity().
| > 
| > Oh, yes, that's because Tom just added them to i386 syscall.master
| > in order to restore the build when linux_sched_{get|set}affinity()
| > were not ifdef LINUX_NPTL. I did not noticed it. A build break for a
| > build break :-)
| > 
| > The simpliest way is probably to back out that change. Tom, is it
| > okay for you?
| 
| Err, if linux_sched_{get|set}affinity() doesn't require other
| LINUX_NPTL code, it should rather be added to all ports, shouldn't
| it?

I suppose that you only want linux_sched_{get|set}affinity() when you
want LINUX_NTPL to be defined. The problem is that there is no way to
dinamicaly define entries under syscalls.master based on pre-processor
directives.

                -- Rui Paulo

Attachment: pgpUBPJC55FT6.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index