Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/share/man/man9



On Mon, Oct 24, 2005 at 10:40:32AM -0700, Jason Thorpe wrote:
> 
> On Oct 24, 2005, at 10:12 AM, Bill Studenmund wrote:
> 
> >This documentation also is the direct result of one of my SoC projects
> >stalling for about a week as the student assumed bno was in device  
> >blocks,
> >and then nothing worked. When he switched it to DEV_BSIZE blocks,  
> >things
> >started working.
> >
> >I strongly believe that we need enough documentation so that someone
> >looking at this man page can figure out what units to use for blkno  
> >for
> >bread() and bwrite().
> 
> I agree with Bill 100% here.  We might not like the current  
> situation, but we should at least document it.
> 
> (I also agree with Chuq that we should simply switch to using bytes  
> for this everywhere...)

Yeah, Chuq and I have talked about this in the past. Way back when I was 
at NASA, I worked on one get-rid-of-DEV_BSIZE method. I changed jobs 
before finishing, and Chuq finished it differently (as we have it now). 
It's really a matter of where we want to shove the work; it does all even 
out in the end.

My one thought about bytes vs DEV_BSIZE vs device block size is just that 
it would be nice to choose something that makes all the calculations 
to&from whatever we use in the interface fast, since they are in the 
fast-path. :-)

Take care,

Bill

Attachment: pgpDrhoukmOt4.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index