Re: CVS commit: src/sys/dev/ic

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

david%l8s.co.uk@localhost wrote:

> > Whele here, change style of some byteswap ops from
> >     foo = bar();
> >     foo = ahc_htole32(foo);
> > to
> >     foo = ahc_htole32(bar());
> 
> That is likely to break the code.
> The underlying htole32() code could easily be a #define that
> evalautes its argument more than once.

IMHO, such macro is broken and should be fixed.
Anyway, most our other drivers use the latter.
---
Izumi Tsutsui