Re: CVS commit: src/sys/arch/alpha/alpha

[Havard Eidnes <he%uninett.no@localhost>]

> he%NetBSD.org@localhost said:
> > Modified Files:
> >     src/sys/arch/alpha/alpha: trap.c
> > Log Message: Now that uvm_extern.h no longer includes uvm_fault.h, we
> > need to include the latter explicitly. 
>
> I have the impression that the VM_FAULT_INVALID and
> VM_FAULT_PROTECT flags are not used anywhere and
> can be removed completely.

Well, a grep and test-compile says otherwise:


quattro: {1} cd /u/build/HEAD/src/sys/arch/alpha/alpha
quattro: {2} egrep -3 'VM_FAULT_INVALID|VM_FAULT_PROTECT' trap.c
                        va = trunc_page((vaddr_t)a0);
                        rv = uvm_fault(map, va,
                            (a1 == ALPHA_MMCSR_INVALTRANS) ?
                            VM_FAULT_INVALID : VM_FAULT_PROTECT, ftype);

                        /*
                         * If this was a stack access we keep track of the
quattro: {3} cvs status trap.c
===================================================================
File: trap.c            Status: Locally Modified

   Working revision:    1.98    Thu Jul 28 23:16:16 2005
   Repository revision: 1.98    /u/nb/src/sys/arch/alpha/alpha/trap.c,v
   Sticky Tag:          (none)
   Sticky Date:         (none)
   Sticky Options:      (none)

quattro: {4}

and

    compile  GENERIC/trap.o
/u/build/HEAD/src/sys/arch/alpha/alpha/trap.c: In function `trap':
/u/build/HEAD/src/sys/arch/alpha/alpha/trap.c:505: error: `VM_FAULT_INVALID' 
undeclared (first use in this function)
/u/build/HEAD/src/sys/arch/alpha/alpha/trap.c:505: error: (Each undeclared 
identifier is reported only once
/u/build/HEAD/src/sys/arch/alpha/alpha/trap.c:505: error: for each function it 
appears in.)
/u/build/HEAD/src/sys/arch/alpha/alpha/trap.c:505: error: `VM_FAULT_PROTECT' 
undeclared (first use in this function)

*** Failed target:  trap.o

Regards,

- Håvard