Re: CVS commit: src/lib

[christos%zoulas.com@localhost (Christos Zoulas)]

In article <20041027195924.8E2462DA1D%cvs.netbsd.org@localhost>,
David Laight <dsl%netbsd.org@localhost> wrote:
>
>Module Name:   src
>Committed By:  dsl
>Date:          Wed Oct 27 19:59:24 UTC 2004
>
>Modified Files:
>       src/lib/libc/gen: fmtcheck.c
>       src/lib/libc/stdlib: strtod.c
>       src/lib/libedit: emacs.c
>       src/lib/libform: type_alnum.c type_alpha.c type_integer.c
>           type_numeric.c
>       src/lib/libskey: put.c
>       src/lib/libtelnet: genget.c
>       src/lib/libusbhid: usage.c
>
>Log Message:
>Fix a load of international alphabet problems with isxxx() and toupper()
>Change isspace(*char_ptr) to isspace(*char_ptr & 0xff) so that the correct
>piece of memory is looked at for the bit mask.
>gcc optimises out the '& 0xff' (on i386 at least).
>Fixes problems found by gcc when the splurious (int) cast is removed

Why didn't you cast to (unsigned char) as is the current practice everywhere
else in the code?!?

christos