Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libc/arch/x86_64/string



simonb%wasabisystems.com@localhost said:
> > fix alignment check for source
> > should fix PR port-amd64/26416 by Nicolas Joly
> 
> Can we construct a regression test for this?

It is not so easy - the bug only became visible with
electricfence. (which puts an unmapped page just behind
the end of malloc()ed memory)
We'd have to mimic this for the test, using mmap()/mprotect()
or so.
When I have time...

> it wasn't too easy to track down...

If you look at the fix you'll see that it was a very simple
bug... I should have spotted it before:-(

best regards
Matthias





Home | Main Index | Thread Index | Old Index