Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/share/mk



On Sat, Oct 18, 2003 at 08:58:42PM +0000, John Hawkinson wrote:
  | > Implement MAKEVERBOSE to control how "verbose" the standard make(1) rules 
are.
  | > Supported values:
  | >     0     Minimal output ("quiet")
  | >     1     Describe what is occurring
  | >     2     Describe what is occurring and echo the actual command 
("verbose")
  | >   This is the default, and is equivalent to the previous behaviour.
  | 
  | I'm pretty disappointed you didn't see fit to address the concerns
  | I raised about the sense of this being backwards. Any particular
  | you reason you did not reply before your implementation? I would
  | have appreciated knowing how you were going to implement this before
  | you did it.

FWIW: the general feedback I have received about this work has been
positive.

You were asking for what I consider to be a minor semantic difference
in how this is controlled (MAKEVERBOSE versus your MAKEBRIEF), and
one that I didn't feel had enough justification to change from I'd
already done, especially since no-one else expressed any similar
sentiments to yours.

In any case, the method the infrastructure is controlled is based on
one set of checks of MAKEVERBOSE in <bsd.own.mk>; if it turns out in
our experience using the mechanism shows us that your MAKEBRIEF
semantics are better/make more sense, it's trivial to change.

Having the MAKEVERBOSE stuff available to more than just the "build.sh"
infrastructure is useful as well; this came up in my discussions with
a few people about this stuff before it was committed.



Home | Main Index | Thread Index | Old Index