Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sbin/newfs



On Fri, Oct 10, 2003 at 11:07:52AM +0100, David Laight wrote:
> >    > i think it would be best if newfs Just Worked with vinum devices.
> >    
> >    No question.  Do you have any suggestion how?  I suppose one way would
> >    be to ignore errors if you can't get the partition information
> >    indicated by the last letter.  Another, tacky one would be to
> >    recognize the path name (/dev/vinum) and go by that.  But that's even
> >    worse than the -V flag.
> 
> The partition size could be got from stat, the label is only needed
> for the sector size.  It is also used as defaults for the fragment/block
> size and to validate the appleufs stuff.
> 
> IMHO the fragment/block sizes don't belong in the label!
> And newfs shouldn't be writing the label....

Yes, actually, it should be in the disklabel. Well, it should be in the
partition info. It's there so that we widen the range of severe superblock
failure issues we can deal with. My understanding is that with those
values (block/frag/cpg), it's easy to calculate where alternate
superblocks are, so we can easily find them.

Take care,

Bill

Attachment: pgpGdJPMrpLFx.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index