Re: CVS commit: src/gnu/dist/cvs/src

[John Hawkinson <jhawk%mit.edu@localhost>]

Christos Zoulas <christos%netbsd.org@localhost> wrote on Thu, 25 Sep 2003
at 16:10:14 +0000 in <20030925161014.759CE2DA1D%cvs.netbsd.org@localhost>:

> Module Name:  src
> Committed By: christos
> Date:         Thu Sep 25 16:10:14 UTC 2003
> 
> Modified Files:
>       src/gnu/dist/cvs/src: commit.c cvs.h logmsg.c modules.c run.c server.c
> 
> Log Message:
> Add charles's SETXID_SUPPORT patches for setuid() runs.

This is not the most descriptive log message. It should be better, I
think. What are these patches intended to do, and how do they work?
Clearly they effect setuid behavior.

Also, rev 1.11 of server.c has:

@@ -772,8 +772,7 @@
        nothing.  But for rsh, we need to do it now.  */
     parse_config (current_parsed_root->directory);
 
-    if (!nolock)
-    {
+    if (!nolock) {
     path = xmalloc (strlen (current_parsed_root->directory)
                   + sizeof (CVSROOTADM)
                   + 2);

That sort of thing shoulodn't be happening, right?

Perhaps it (that hunk) should be reverted to simply future
merging.

--jhawk