CVS commit: src/sys/dev/pci

[Thor Lancelot Simon <tls%netbsd.org@localhost>]

Module Name:    src
Committed By:   tls
Date:           Mon Sep  1 06:30:25 UTC 2003

Modified Files:
        src/sys/dev/pci: amdpm.c

Log Message:
Revert previous change, which was wrong.  As Enami points out, we really do
want the NO_ESTIMATE flag here, because if the source doesn't have it,
rnd_add_data will *use the time the data was added directly as entropy*,
which is not a good idea either for a hardware RNG that works like this
one (periodically polled by the driver) or, really, like any other that I've
seen, because even for "interrupt when ready" RNGs the data rate (and thus
interrupt time) will vary only slightly for a given RNG configuration over
time, if at all.

The data we add _is_ counted into the pool estimage because we directly
pass in an entropy estimate.

The overloading of the NO_ESTIMATE flag with this meaning seems, to me, like
a design bug (albeit easily fixed) in the rng interface; but until that's
changed, we need to use it here.


To generate a diff of this commit:
cvs rdiff -r1.6 -r1.7 src/sys/dev/pci/amdpm.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.