Re: CVS commit: src/usr.bin/vi/common

[christos%zoulas.com@localhost (Christos Zoulas)]

On Apr 20, 11:23pm, Aymeric.Vincent%labri.fr@localhost (Aymeric Vincent) wrote:
-- Subject: Re: CVS commit: src/usr.bin/vi/common

I agree, and I mentioned that my fix is a stopgap fix. I don't know
if it is db's fault. Until someone proves the vi can write reliable
files with db3 and not with db1... As for assigning PR's to this,
I suggest we close them all and open a new one to import the new nvi
in order to fix the recovery problem, with the closing message being
superseeded by PR/nnnnn.

christos

| Thank you for doing this. I'd like to point you at PR 14902
| http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=14902
| 
| I assigned it to me because I think the real problem is in DB writing
| junk files, and I thought I would look at it on a "long term" basis.
| If your fix prevents vi from crashing with the example file provided
| in the PR, please consider assigning the PR to you and/or changing its
| state.
| 
| As far as updating nvi is concerned, the current goal is to wait for a
| nvi > 1.81.5 because the new version will likely break the compat
| layer I wrote for nvi 1.81.x to enable it to use DB1 instead of DB3.
| Note that since the imported nvi will still use our libdb, I'm afraid
| the core of the problem will remain.
| 
| Kind regards,
|  Aymeric
| 
| christos%zoulas.com@localhost (Christos Zoulas) writes:
| 
| > On Apr 18, 11:36am, thorpej%wasabisystems.com@localhost (Jason Thorpe) 
wrote:
| > -- Subject: Re: CVS commit: src/usr.bin/vi/common
| > 
| > Importing a newer nvi is probably a *lot* easier than dealing with this
| > kind of bug. This fix is a stopgap measure as mentioned in the commit
| > message.
| > 
| > christos
| > 
| > | I think a better solution would be to prevent the DB from getting 
| > | corrupted in the first place!
| > | 
| > |          -- Jason R. Thorpe <thorpej%wasabisystems.com@localhost>
| > -- End of excerpt from Jason Thorpe
-- End of excerpt from Aymeric Vincent