Re: CVS commit: syssrc/sys

[Jaromir Dolecek <jdolecek%netbsd.org@localhost>]

Luke Mewburn wrote:
> On Sat, Dec 07, 2002 at 09:48:32PM +0200, Andrew Doran wrote:
> > Module Name:        syssrc
> > Committed By:       ad
> > Date:               Sat Dec  7 19:48:32 UTC 2002
> > 
> > Modified Files:
> >     syssrc/sys/arch/i386/conf: majors.i386
> >     syssrc/sys/dev/eisa: dpt_eisa.c
> >     syssrc/sys/dev/i2o: dptivar.h
> >     syssrc/sys/dev/ic: dpt.c dptvar.h
> >     syssrc/sys/dev/isa: dpt_isa.c
> >     syssrc/sys/dev/pci: dpt_pci.c
> > 
> > Log Message:
> > Implement the DPT EATA ioctl() interface.
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.32 -r1.33 syssrc/sys/dev/ic/dpt.c
> 
> this change prevents this file from compiling on 64 bit platforms such
> as alpha and sparc64.  c.f:
>     http://releng.netbsd.org/ab/B_HEAD/M_sparc64/sparc64.relse.1039392000.txt
>     http://releng.netbsd.org/ab/B_HEAD/M_alpha/alpha.relse.1039392000.txt

I looked on ic/dpt.c a bit, and it seems the code uses value taken
from htobe32() later for copyin(). So it appears it has only
chance of working on big endian 32bit machines.

Jaromir
-- 
Jaromir Dolecek <jdolecek%NetBSD.org@localhost>            
http://www.NetBSD.org/
-=- We should be mindful of the potential goal, but as the tantric    -=-
-=- Buddhist masters say, ``You may notice during meditation that you -=-
-=- sometimes levitate or glow.   Do not let this distract you.''     -=-