Re: CVS commit: basesrc/lib/libutil

[Ross Harvey <ross%ghs.com@localhost>]

I suppose this isn't a very important issue (netbsd-specific internal
library interface and all that) but could you expand on the reason
for this additional check?

I'm sure I'm just missing a perfectly good reason for doing it,
but at first glance it seems like it just takes some calls that
were about to succeed and errors them out.

E.g. (and ok, sure, one should really let opendisk(3) find the raw
partition pathname) the following _used_ to work and now fails:

        vnconfig /dev/vnd2c ...

>From an interface standpoint, it seems like the error check would
only make sense if there was a don't-care wildcard (<0?) for
iscooked.

        Ross

> From: Luke Mewburn <lukem%netbsd.org@localhost>
>
>
> Module Name:  basesrc
> Committed By: lukem
> Date:         Thu Nov  1 06:53:25 UTC 2001
>
> Modified Files:
>       basesrc/lib/libutil: opendisk.3 opendisk.c
>
> Log Message:
> Enforce is iscooked arg;
>       if zero, a matching path must be of type S_IFBLK, and
>       if non-zero, a matching path must be of type S_IFCHR.
>
>
> To generate a diff of this commit:
> cvs rdiff -r1.5 -r1.6 basesrc/lib/libutil/opendisk.3
> cvs rdiff -r1.7 -r1.8 basesrc/lib/libutil/opendisk.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>