Re: CVS commit: syssrc/sys/dev/cardbus

[Klaus Klein <kleink%reziprozitaet.de@localhost>]

"Perry E. Metzger" <perry%wasabisystems.com@localhost> writes:

> enami tsugutomo <enami%sm.sony.co.jp@localhost> writes:
> > "Perry E. Metzger" <perry%wasabisystems.com@localhost> writes:
> > > > Don't use __func__ as variable.  It prevents compilation.
> > > > Use __FUNCTION__ instead.
> > > 
> > > This is a step backwards.
> > > 
> > > __FUNCTION__ is a gcc extension. __func__ is C99. Please use __func__,
> > > not __FUNCTION__.
> > 
> > But pre-NEW_TOOLCHAIN compiler doesn't recognize __func__ (that's why
> > it was able to be used for other purpose).
> 
> Oh, I see what you mean.
> 
> It is still wrong. __FUNCTION__ is special to gcc! You have to name
> the thing something else.

In that case, you might want to consider putting something like the
__assert_function__ definition from <assert.h> into <sys/cdefs.h>
under an appropriate name, and update KNF accordingly.


- Klaus