Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: basesrc



| 
| Module Name:  basesrc
| Committed By: ad
| Date:         Fri Jul  7 14:09:42 UTC 2000
| 
| Modified Files:
|         basesrc/usr.bin/newsyslog: newsyslog.c
| 
| Log Message:
| Redo previous slightly; add `-m' option to allow multiple instances.


This change, and the previous:

| Don't allow more than one instance when running as root.

do not make sense to me. You're (by default) restricting behavior
that people may be using, for no clear gain. Yes, the pidfile
might be overwritten. Yes, if you don't run with a seperate
configuration file you might have a problem. But it's not normal
for our daemons to prevent you from running multiple copies unless
they require a lock on a resource, and that's not the case here.

Can you please justify this a bit better? I think many of these
recent newsyslog changes should have had discussion on tech-userlevel
first. This would save you from having to back them out.


Also, you have not updated the documentation for this behavior.

My preference would be for these two to be backed out, but if not they
should be documented at the same time as the change is committed.

--jhawk



Home | Main Index | Thread Index | Old Index