Re: CVS commit: basesrc

[cgd%netbsd.org@localhost (Chris G. Demetriou)]

Dave Sainty <dave%dtsp.co.nz@localhost> writes:
> Does any system define it differently now?

It doesn't matter.

it's in the implementation namespace.  if we want our yacc output
files to be portable -- and it should be obvious that that's the right
default -- then they have to avoid non-portable assumptions.
assumptions about what's in the implementatation namespace is how it
works is non-portable.  (This can be taken to a ridiculous extreme.
If somebody else is defining __NetBSD__ and isn't NetBSD, well, they
shouldn't be doing that and they deserve to break, just like we would
if we defined _SVR4 or whatever by default.  However, there _is_ some
tiny bit of merit to be had in claiming that we shouldn't include this
feature/#ifdef test for just this reason...  this extreme is truly
stupid, but it depends on how portable you want to be.)

indeed, it really should be defined(__NetBSD__) && defined(__RCSID)
so the yacc output files will be usable on old versions of NetBSD if
need be!


cgd
-- 
Chris Demetriou - cgd%netbsd.org@localhost - 
http://www.netbsd.org/People/Pages/cgd.html
Disclaimer: Not speaking for NetBSD, just expressing my own opinion.