Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



> Module Name:    src
> Committed By:   thorpej
> Date:           Sat Nov  7 22:20:15 UTC 2026
> ...
> Removed Files:
>         src/sys/ddb: db_active.h
> 
> Log Message:
> Make db_active ABI-stable by always including it in kern_stub.c.  Put its
> extern decl in <sys/systm.h> and eliminate <ddb/db_active.h>.

I'm fine with making db_active ABI-stable, but why did you move it to
sys/systm.h?

We should tend toward exactly the opposite preference: fine-grained
purpose-limited header files like db_active.h, not giant incoherent
hodgepodges like systm.h touching any of which causes the entire
kernel to be rebuilt.

Can you please put ddb/db_active.h back?


Home | Main Index | Thread Index | Old Index