Re: CVS commit: src

[Andrius V <vezhlys%gmail.com@localhost>]

On Sun, May 10, 2026 at 5:19 PM Thor Lancelot Simon <tls%netbsd.org@localhost> wrote:
>
> Module Name:    src
> Committed By:   tls
> Date:           Sun May 10 14:19:11 UTC 2026
>
> Modified Files:
>         src/distrib/sets: sets.subr
>         src/distrib/sets/lists/debug: ad.mips ad.mipseb ad.mipsel md.emips
>             md.evbarm.earmv4 md.evbarm.earmv5 md.evbarm.earmv5eb md.evbppc
>             md.pmax mi
>         src/etc: Makefile
>         src/share/mk: bsd.own.mk
>         src/sys/arch/alpha/conf: INSTALL
>         src/sys/conf: Makefile.kern.inc
>
> Log Message:
> Fix MKDEBUGKERNEL vs MKDEBUG for kernel debug file sets.
>
> The problem manifests as checkflist failures when building ports that
> have extensive ALL_KERNELS but not...building all the kernels; notably
> the various "evb" ports with a bazillion kernels for a bazillion SoCs.
>
> The mk.conf(5) man page documents MKDEBUGKERNEL as controlling
> whether kernel debug files (netbsd-*.debug) appear in the
> distribution sets.  However, the prior implementation used MKDEBUG
> (the general userland debug flag) instead.
>
> This meant MKDEBUG=yes with MKDEBUGKERNEL=no incorrectly expected
> kernel debug files for every kernel config listed in ALL_KERNELS.
> When only a subset of kernels is built, checkflist fails with
> missing files.
>
> The fix is to make these variables fully conform to the longstanding
> documentation.  MKDEBUGKERNEL controls whether kernel debug symbols are
> built; MKDEBUG controls everything else.  If you want something like the
> old behavior but minus the bugs, set both.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.214 -r1.215 src/distrib/sets/sets.subr
> cvs rdiff -u -r1.87 -r1.88 src/distrib/sets/lists/debug/ad.mips
> cvs rdiff -u -r1.7 -r1.8 src/distrib/sets/lists/debug/ad.mipseb \
>     src/distrib/sets/lists/debug/ad.mipsel
> cvs rdiff -u -r1.3 -r1.4 src/distrib/sets/lists/debug/md.emips
> cvs rdiff -u -r1.1 -r1.2 src/distrib/sets/lists/debug/md.evbarm.earmv4 \
>     src/distrib/sets/lists/debug/md.evbarm.earmv5 \
>     src/distrib/sets/lists/debug/md.evbarm.earmv5eb
> cvs rdiff -u -r1.5 -r1.6 src/distrib/sets/lists/debug/md.evbppc
> cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/lists/debug/md.pmax
> cvs rdiff -u -r1.512 -r1.513 src/distrib/sets/lists/debug/mi
> cvs rdiff -u -r1.475 -r1.476 src/etc/Makefile
> cvs rdiff -u -r1.1481 -r1.1482 src/share/mk/bsd.own.mk
> cvs rdiff -u -r1.120 -r1.121 src/sys/arch/alpha/conf/INSTALL
> cvs rdiff -u -r1.305 -r1.306 src/sys/conf/Makefile.kern.inc
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>

Hi,

I believe this commit fixes PR 59233 and PR 57846 (MKDEBUG doesn't
fail on current now for evbmips release, NetBSD 11 still does).

Not sure how important is to pullup these changes to netbsd-10 or
netbsd-11? Or should we just close those tickets?

Regards,
Andrius V