Re: CVS commit: src/sys/dev

[Michael van Elst <mlelstv%serpens.de@localhost>]

On Sat, Apr 12, 2025 at 06:24:44PM +0900, Rin Okuyama wrote:
> Hi!
> 
> I've made a draft patch to support dumping against > 2Gi blocks
> for backends like nvme(4) or virtio(4).
> 
> Does it look reasonable to you?



Hi rin,


> -	if (blkno < 0 || blkno + nblk - 1 > INT_MAX)
> +	if (blkno < 0 ||
> +	    ((sc->sc_flags & LDF_BLOCK32) != 0 && blkno + nblk > UINT32_MAX))
>  		return (EIO);


I think the check for the upper bound needs to be like I wrote it so
that the last block written doesn't exceed the maximum signed int value.

Otherwise it looks ok.

The current version (check only) could be pulled up. The changed
backend ABI would require more compat code.


Greetings,
-- 
                                Michael van Elst
Internet: mlelstv%serpens.de@localhost
                                "A potential Snark may lurk in every tree."