Re: CVS commit: src/sys/arch/mac68k/dev

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

Hi,

Can you please localize this quirk only for the affected machines?
It seems too much to me, to have 5 sec delay for irrelevant machines.

Thanks,
rin

On 2024/09/15 5:56, Nathanial Sloss wrote:
> Module Name:	src
> Committed By:	nat
> Date:		Sat Sep 14 20:56:51 UTC 2024
>
> Modified Files:
> 	src/sys/arch/mac68k/dev: adb.c
>
> Log Message:
> Allow a few seconds for adb devices to settle.
>
> The spin up of the floppy drive motor would cause a crash on my PowerBook
> when adb was attached.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.59 -r1.60 src/sys/arch/mac68k/dev/adb.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>
> Modified files:
>
> Index: src/sys/arch/mac68k/dev/adb.c
> diff -u src/sys/arch/mac68k/dev/adb.c:1.59 src/sys/arch/mac68k/dev/adb.c:1.60
> --- src/sys/arch/mac68k/dev/adb.c:1.59	Sat Aug  7 16:18:57 2021
> +++ src/sys/arch/mac68k/dev/adb.c	Sat Sep 14 20:56:50 2024
> @@ -1,4 +1,4 @@
> -/*	$NetBSD: adb.c,v 1.59 2021/08/07 16:18:57 thorpej Exp $	*/
> +/*	$NetBSD: adb.c,v 1.60 2024/09/14 20:56:50 nat Exp $	*/
>   
>   /*
>    * Copyright (C) 1994	Bradley A. Grantham
> @@ -26,7 +26,7 @@
>    */
>   
>   #include <sys/cdefs.h>
> -__KERNEL_RCSID(0, "$NetBSD: adb.c,v 1.59 2021/08/07 16:18:57 thorpej Exp $");
> +__KERNEL_RCSID(0, "$NetBSD: adb.c,v 1.60 2024/09/14 20:56:50 nat Exp $");
>   
>   #include "opt_adb.h"
>   
> @@ -94,6 +94,9 @@ static void
>   adbattach(device_t parent, device_t self, void *aux)
>   {
>   
> +	printf("...  Waiting 5 seconds for adb devices to settle.");
> +	kpause("adb-slp", false, mstohz(5000), NULL);
> +
>   	adb_softintr_cookie = softint_establish(SOFTINT_SERIAL,
>   	    (void (*)(void *))adb_soft_intr, NULL);
>   	printf("\n");