Re: CVS commit: src/external/bsd/ntp/lib/libntp

[Martin Husemann <martin%duskware.de@localhost>]

On Fri, Apr 19, 2024 at 04:36:46PM +0700, Robert Elz wrote:
> I don't understand that change, it altered from
> 
> 	MKREPRO_DATE != ${TOOL_DATE} -u -r "${MKREPRO_TIMESTAMP}" "+%F"
> to
> 	MKREPRO_DATE != ${TOOL_DATE} -u -r "${MKREPRO_TIMESTAMP}" "+%b %d %Y"
> 
> %F is simply a shorthand for %Y-%m-%d (which is the correct way to write
> locale independent dates), %b is a locale dependent name of the month, and
> what's more this is in US-centric mon day year format, which we should avoid
> (aside from anything else, it is a dumb format, with the smallest value unit
> sitting in the middle, rather than at one end or the other).

The problem (IIUC) is that the ntp code parses this value internally, so
it won't talk to anyone claiming a time before the time ntpd was compiled
(or something along that line).

And __DATE__ gives us a stupid format: 

	 > echo __DATE__ | cc -E - | tail -1
	"Apr 19 2024"

which is different from

	 > date -u -r 1713530399 "+%F"
	2024-04-19

but matches

	> date -u -r 1713530399 "+%b %d %Y"
	Apr 19 2024


The commit message could have explained that a bit.

Martin