Re: CVS commit: src/games/larn

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Sun, Mar 24, 2024 at 21:21:39 +0200, Andrius V wrote:

> Can you a bit clarify the meaning of "8 space tabs"

This is what VT set up screen called "Set 8 Column Tabs", i.e. "set
one tab every eight columns, starting at column 9" which was the
default setting.

https://vt100.net/docs/tp83/chapter4.html#T4-11
https://vt100.net/docs/vt420-uu/chapter5.html#S5.11

Emacs calls this tab-width.  vi, I believe calls it tabstop.  Both
default to 8.

I know this is a subject that people are often religious about, but I
think it's reasonable to require that when a file is cat(1) to the
terminal (say, vt220) or an emulator (say, xterm) in it's default
state, it displays as intended.


> since file is not exactly following any completely defined pattern.

I haven't looked at the rest of the file too closely, but the indented
multi-line comments I referred to are definitely meant to be viewed
with 8 space tabs and in general the 8 space tabs are the default (see
above).  If some parts of that file deviate from that they should be
fixed, but I was referring specifically to your change that looks like
this with the default 8 column tabs (untabified to ensure that it's
displayed the same regardless of the viewer's tab settings):

 * setupvt100()         Subroutine to set up terminal in correct mode for game
 * clearvt100()         Subroutine to clean up terminal when the game is over
 * ttgetch()            Routine to read in one character from the terminal
 * scbr()                       Function to set cbreak -echo for the terminal
 * sncbr()                      Function to set -cbreak echo for the terminal
 * newgame()            Subroutine to save the initial time and seed rnd()


That text looks aligned with 4 column tabs (again, the text below is
untabified):

 * setupvt100()     Subroutine to set up terminal in correct mode for game
 * clearvt100()     Subroutine to clean up terminal when the game is over
 * ttgetch()        Routine to read in one character from the terminal
 * scbr()           Function to set cbreak -echo for the terminal
 * sncbr()          Function to set -cbreak echo for the terminal
 * newgame()        Subroutine to save the initial time and seed rnd()

If you would like to go and fix the rest of the file, that would be
nice, but my request was to at least not introduce more non-standart
tabs.

Thanks!

-uwe