Re: CVS commit: src/usr.sbin/inetd

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Mon, 30 Aug 2021 18:21:11 +0000
Roland Illig <rillig%netbsd.org@localhost> wrote:

> Module Name:	src
> Committed By:	rillig
> Date:		Mon Aug 30 18:21:11 UTC 2021
> 
> Modified Files:
> 	src/usr.sbin/inetd: Makefile inetd.c parse_v2.c
> 
> Log Message:
> inetd: raise WARNS from 5 to 6

clang complains:

/work/src/usr.sbin/inetd/inetd.c:763:18: error: implicit conversion changes signedness: 'service_type' (aka 'enum service_type') to 'int' [-Werror,-Wsign-conversion]
                        SWAP(int, cp->se_type, sep->se_type);
                        ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

Works for me:

--- inetd.c     30 Aug 2021 18:21:11 -0000      1.131
+++ inetd.c     31 Aug 2021 16:26:45 -0000
@@ -760,7 +760,7 @@ config(void)
 #ifdef IPSEC
                        SWAP(char *, sep->se_policy, cp->se_policy);
 #endif
-                       SWAP(int, cp->se_type, sep->se_type);
+                       SWAP(enum service_type, cp->se_type, sep->se_type);
                        SWAP(size_t, cp->se_service_max, sep->se_service_max);
                        SWAP(size_t, cp->se_ip_max, sep->se_ip_max);