re: CVS commit: src/tests/lib/csu

[matthew green <mrg%eterna.com.au@localhost>]

Christos Zoulas writes:
> In article <YLwTlSapbfxOELc1%bec.de@localhost>, Joerg Sonnenberger  <joerg%bec.de@localhost> wrote:
> >On Fri, Jun 04, 2021 at 10:20:24PM -0000, Christos Zoulas wrote:
> >> In article <YLlbSLViz+QoIFc3%bec.de@localhost>, Joerg Sonnenberger 
> ><joerg%bec.de@localhost> wrote:
> >> >On Thu, Jun 03, 2021 at 04:17:37PM -0400, Christos Zoulas wrote:
> >> >> Module Name:	src
> >> >> Committed By:	christos
> >> >> Date:		Thu Jun  3 20:17:37 UTC 2021
> >> >> 
> >> >> Modified Files:
> >> >> 	src/tests/lib/csu: h_ifunc_static.c
> >> >> 
> >> >> Log Message:
> >> >> PR/56230: Jan-Benedict Glaw: arm oabi does not and will not have ifunc
> >> >support.
> >> >
> >> >As I mentioned elsewhere, I disagree with this change. OABI is dead and
> >> >only really support for legacy compatibility. All the OABI build
> >> >variants should be removed and this is strongly a step in the wrong
> >> >direction.
> >> 
> >> I think it is better to do it after the 10 branch. It is not just removing
> >> the build.sh targets, we need to remove the compat glue and fix the sets,
> >> and perhaps something else I am missing. I will revert the two changes
> >> once we remove all oabi support.
> >
> >I don't see how that's related. I'm not talking about removing the
> >compat layer right now. Remove the build.sh targets and call it a day.
>
> CC:ed tech-toolchain. Does everyone agree to remove the oabi build targets?

AFAICT, GCC removed the basic oabi targets recently, which
is why they weren't updated.  we have some dead code in our
gcc/arm port in the GCC 10 tree.  you can still target oabi
with compiler options, but there are no configurations that
default to it any more.

at this point i'm also wanting to turn off the compat libs
for everyone entirely -- if you have old oabi apps, you're
welcome to use old libs to run them, same as eg, when we
switched from a.out to ELF originally.  this is *not* the
kernel support to run these apps.

ie, remove it from build.sh and share/mk/ ASAP -- before the
netbsd 10 branch.


.mrg.