Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/xlint/lint1



In article <20210418085205.10B75FA96%cvs.NetBSD.org@localhost>,
Roland Illig <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:	src
>Committed By:	rillig
>Date:		Sun Apr 18 08:52:04 UTC 2021
>
>Modified Files:
>	src/usr.bin/xlint/lint1: err.c externs1.h lint1.h
>
>Log Message:
>lint: add error_at, warning_at, message_at
>
>Right now there are several places in the code that use the global
>variable curr_pos for passing a parameter to the diagnostic functions.
>That's not what global variables are for.
>
>Make it easy for the code to migrate to the parameter-passing style.
>

Isn't it better to pass "const pos_t *", instead of pos_t which needs to
copy the struct?

christos



Home | Main Index | Thread Index | Old Index