Re: CVS commit: src/sys/arch/powerpc/ibm4xx

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2021/01/18 13:35, Rin Okuyama wrote:
> Module Name:	src
> Committed By:	rin
> Date:		Mon Jan 18 04:35:05 UTC 2021
>
> Modified Files:
> 	src/sys/arch/powerpc/ibm4xx: clock.c
>
> Log Message:
> Invoke hardclock() and statclock() in the interrupt context.
>
> Otherwise, entropy_enter() is used instead of entropy_enter_intr() in
> statclock(), which results in KASSERT() failure.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.30 -r1.31 src/sys/arch/powerpc/ibm4xx/clock.c

This message is somewhat misleading. I meant:

(1) Callers are interrupt handlers, therefore, {hard,stat}clock() are
    apparently invoked in the interrupt context.

(2) However, in clock.c rev 1.31 and prior, curcpu->ci_idepth was not
    raised before calling {hard,stat}clock(). Therefore, cpu_intr_p()
    wrongly returns false. As a result, callee functions misunderstood
    that they are not running in the interrupt context.

I have to improve my English writing skills ;-).

Thanks,
rin