Re: CVS commit: src/sys

[Paul Goyette <paul%whooppee.com@localhost>]

I am getting errors, too, when I build a NOCOMPAT kernel:

#      link  NOCOMPAT/netbsd
/build/netbsd-compat/tools/x86_64/amd64/bin/x86_64--netbsd-ld -Map netbsd.map --cref -T netbsd.ldscript -Ttext 0xffffffff80200000 -e start -z max-page-size=0x200000 -X -o netbsd ${SYSTEM_OBJ:[@]:Nswapnetbsd.o} ${EXTRA_OBJ} vers.o swapnetbsd.o
/build/netbsd-compat/tools/x86_64/amd64/bin/x86_64--netbsd-ld: kern_core.o: in function `coredump_modcmd':
/build/netbsd-compat/src_ro/sys/kern/kern_core.c:91: undefined reference to `real_coredump_elf32'
*** [netbsd] Error code 1


On Tue, 20 Oct 2020, Rin Okuyama wrote:

> Hi,
>
> This causes build failures for LP64 archs without COMPAT_NETBSD32,
> i.e., alpha and ie64:
>
> kern_core.o: in function `coredump_modcmd':
> (.text+0x1c4): undefined reference to `real_coredump_elf32
>
> https://releng.netbsd.org/builds/HEAD/202010200300Z/
>
> (Failure for aarch64eb is irrelevant, and already fixed by ryo.)
>
> Protect the code with COMPAT_NETBSD32 or EXEC_ELF32?
>
> Thanks,
> rin
>
> On 2020/10/20 4:33, Christos Zoulas wrote:
> > Module Name:	src
> > Committed By:	christos
> > Date:		Mon Oct 19 19:33:02 UTC 2020
> >
> > Modified Files:
> > 	src/sys/arch/amd64/conf: MODULAR files.amd64
> > 	src/sys/kern: compat_stub.c core_elf32.c files.kern kern_core.c
> > 	    kern_sig.c
> > 	src/sys/modules/coredump: Makefile
> > 	src/sys/modules/exec_elf32: Makefile
> > 	src/sys/modules/exec_elf64: Makefile
> > 	src/sys/modules/ptrace_common: Makefile
> > 	src/sys/sys: compat_stub.h exec_elf.h
> > Added Files:
> > 	src/sys/modules/ptrace_common: machdep.mk
> >
> > Log Message:
> > Arrange so that no options COREDUMP and no options PTRACE work together.
> > Thanks to Paul Goyette for testing.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.17 -r1.18 src/sys/arch/amd64/conf/MODULAR
> > cvs rdiff -u -r1.117 -r1.118 src/sys/arch/amd64/conf/files.amd64
> > cvs rdiff -u -r1.19 -r1.20 src/sys/kern/compat_stub.c
> > cvs rdiff -u -r1.65 -r1.66 src/sys/kern/core_elf32.c
> > cvs rdiff -u -r1.52 -r1.53 src/sys/kern/files.kern
> > cvs rdiff -u -r1.30 -r1.31 src/sys/kern/kern_core.c
> > cvs rdiff -u -r1.390 -r1.391 src/sys/kern/kern_sig.c
> > cvs rdiff -u -r1.6 -r1.7 src/sys/modules/coredump/Makefile
> > cvs rdiff -u -r1.5 -r1.6 src/sys/modules/exec_elf32/Makefile
> > cvs rdiff -u -r1.4 -r1.5 src/sys/modules/exec_elf64/Makefile
> > cvs rdiff -u -r1.3 -r1.4 src/sys/modules/ptrace_common/Makefile
> > cvs rdiff -u -r0 -r1.1 src/sys/modules/ptrace_common/machdep.mk
> > cvs rdiff -u -r1.23 -r1.24 src/sys/sys/compat_stub.h
> > cvs rdiff -u -r1.167 -r1.168 src/sys/sys/exec_elf.h
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
>
> !DSPAM:5f8ed8b3121927188711769!

+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+