Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/fdt



On 2020/10/02 22:42, Jonathan A. Kollasch wrote:
On Sun, Jul 21, 2019 at 03:57:24PM +0000, Rin Okuyama wrote:
Module Name:	src
Committed By:	rin
Date:		Sun Jul 21 15:57:24 UTC 2019

Modified Files:
	src/sys/dev/fdt: dw_apb_uart.c

Log Message:
The device cannot recognize break signal. Use +++++ (five plus signs) as
cnmagic in the same manner with bcm2835_com.c.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/fdt/dw_apb_uart.c


This does not appear to be needed on at least one SoC (Allwinner H5).
Which SoC did you have this problem on?

Oops, you are right.

It seems that my device (Allwinner A20) did not accept break signal
because of WSDISPLAY_MULTICONS option. At that time, kernel just
ignored break signal, but today it panics instead. Anyway, by
disabling wsdisplay, I can enter DDB from console by break signal.

I will revert this commit, and request pullup to netbsd-9.

Thank you for finding it out, and I'm sorry for bothering you.

rin


Home | Main Index | Thread Index | Old Index