Re: CVS commit: src/sys

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

matthew green <mrg%eterna.com.au@localhost> wrote:
>"Robert Swindells" writes:
>> Module Name:	src
>> Committed By:	rjs
>> Date:		Mon Aug 10 19:27:28 UTC 2020
>> 
>> Modified Files:
>> 	src/sys/dev: video.c
>> 	src/sys/dev/usb: uvideo.c
>> 	src/sys/sys: videoio.h
>> 
>> Log Message:
>> Add some extra V4L ioctl() requests to latest V4L userland to work.
>> 
>> Import sys/videoio.h from OpenBSD, this is just the Linux headers
>> concatenated together.
>
>this seems very problematic in that you've added GPLv2 code
>into src/sys/sys.

It isn't GPLv2, it is dual licenced.

The header was copied from OpenBSD.

>please revert.

The change was discussed on tech-kern.

>also, these updates to video(4) don't require a kernel bump
>so please revert that too.

They change structures that are passed into the kernel.